[WIP] Solved tap position + solved section count #2978
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Coline PILOQUET <[email protected]>
Signed-off-by: Coline PILOQUET <[email protected]>
|
Thanks for this work! I am going to look at it, with the help of @zamarrenolm because we have to choose the good getter for CGMES SSH and SV exports, and check all the getters and setters. But, before, after a small talk, we agreed on:
|
Signed-off-by: Coline PILOQUET <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Coline PILOQUET <[email protected]>
Signed-off-by: Coline PILOQUET <[email protected]>
Signed-off-by: Coline PILOQUET <[email protected]>
Signed-off-by: Coline PILOQUET <[email protected]>
Signed-off-by: Coline PILOQUET <[email protected]>
colinepiloquet
force-pushed
the
initial_tap_position
branch
from
1b2053b to
bb42f79
Compare
colinepiloquet
changed the title
colinepiloquet
commented
May 7, 2024
| @@ -219,7 +227,7 @@ public ShuntCompensatorImpl add() { | |||
| ShuntCompensatorImpl shunt = new ShuntCompensatorImpl(getNetworkRef(), | |||
There was a problem hiding this comment.
I am not sure how to deal with the validation.
colinepiloquet
commented
May 7, 2024
| @@ -177,6 +179,12 @@ public ShuntCompensatorAdder setSectionCount(int sectionCount) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public ShuntCompensatorAdder setSolvedSectionCount(int solvedSectionCount) { | |||
There was a problem hiding this comment.
Do we want an unset too?
Signed-off-by: Coline PILOQUET <[email protected]> Signed-off-by: Coline PILOQUET <[email protected]>
Signed-off-by: Coline PILOQUET <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: