-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce irrealistic voltage created by remote voltage control #1135
Conversation
684c430
to
e1cc301
Compare
628a958
to
a02e70f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor remarks on the code and I did some typo fix.
src/main/java/com/powsybl/openloadflow/ac/AcloadFlowEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/AcloadFlowEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/outerloop/ReactiveLimitsOuterLoop.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/outerloop/ReactiveLimitsOuterLoop.java
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/outerloop/ReactiveLimitsOuterLoop.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
src/main/java/com/powsybl/openloadflow/ac/outerloop/ReactiveLimitsOuterLoop.java
Show resolved
Hide resolved
Signed-off-by: Didier Vidal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me, except one API design topic (AcSolver) that needs to be though about maybe.
Otherwise just minor comments.
src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowTransformerReactivePowerControlTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/ac/GeneratorRemoteControlPQSwitchTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/ac/GeneratorRemoteControlPQSwitchTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/ac/GeneratorRemoteControlPQSwitchTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, just minor polishing to do.
Please also update the PR description:
- not a breaking change anymore
- mention the new parameter and its default value
src/main/java/com/powsybl/openloadflow/ac/AcLoadFlowParameters.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/outerloop/ReactiveLimitsOuterLoop.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/outerloop/ReactiveLimitsOuterLoop.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/solver/AbstractAcSolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/solver/NewtonKrylov.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
|
Changes addressed. Geoffroy away this week.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #1124
What kind of change does this PR introduce?
A new parameter, voltageRemoteControlRobustMode is introduced. With value true by default.
When the robust mode is set to true,
the reactive limit outerloop is modified as follow:
If the bus of a generator with remote voltage control on , and reactivie limits, is approaches the realistic voltage limit:
- If the bus is outside its reactive limits, it is move PQ (as usual) and its voltage is set to 1pu for the next NR run
- If the bus is inside its reactive limites, it is removed from voltage control (and Q is set to initial targetQ). Its voltage is set to 1pu for the next NR run.
What is the current behavior?
The Newton Raphson fails if a bus reaches a low voltage - a situation that can happen with remoted voltage control due to the PQV model.
What is the new behavior (if this is a feature change)?
With voltageRemoteControlRobustMode set to true (the default value) the resolution of networks with stressed or inconsistent remote voltage targets is more robust.
Does this PR introduce a breaking change or deprecate an API?