Various Adapters: getBoundingClientRect cleanup

[mkomorski]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Updated bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Other information

#11963

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
• modules/omsBidAdapter.js has 29 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[github-actions]

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

• libraries/percentInView/percentInView.js (+3 errors)

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
• modules/omsBidAdapter.js has 29 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[github-actions]

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

• libraries/percentInView/percentInView.js (+1 error)

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
• modules/omsBidAdapter.js has 29 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀