OMS: add video support #3779
Open
OMS: add video support #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
requested changes
Mar 5, 2025
|
|
||
| String pid; | ||
|
|
||
| Integer publisherId; |
There was a problem hiding this comment.
add JsonProperty
also I would change the integration test payload to cover publisherId parameter
There was a problem hiding this comment.
I have cheanged pid to publisherId but IMO its indifferent
Comment on lines
42
to
61
| public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request) { | ||
| String uri = endpointUrl; | ||
|
|
||
| if (!request.getImp().isEmpty()) { | ||
| try { | ||
| final ExtImpOms impExt = parseImpExt(request.getImp().get(0)); | ||
| if (impExt != null) { | ||
| if (impExt.getPid() != null && !impExt.getPid().isEmpty()) { | ||
| uri = String.format("%s?publisherId=%s", endpointUrl, impExt.getPid()); | ||
| } else if (impExt.getPublisherId() != null && impExt.getPublisherId() > 0) { | ||
| uri = String.format("%s?publisherId=%d", endpointUrl, impExt.getPublisherId()); | ||
| } | ||
| } | ||
| } catch (PreBidException e) { | ||
| return Result.withError(BidderError.badInput(e.getMessage())); | ||
| } | ||
| } | ||
|
|
||
| return Result.withValue(BidderUtil.defaultRequest(request, uri, mapper)); | ||
| } |
There was a problem hiding this comment.
I believe it can work this way
try {
final ExtImpOms impExt = parseImpExt(request.getImp().getFirst());
final String publisherId = impExt.getPid() == null && impExt.getPublisherId() != null && impExt.getPublisherId() > 0
? String.valueOf(impExt.getPublisherId())
: impExt.getPid();
final String url = "%s?publisherId=%s".formatted(endpointUrl, publisherId);
return Result.withValue(BidderUtil.defaultRequest(request, url, mapper));
} catch (PreBidException e) {
return Result.withError(BidderError.badInput(e.getMessage()));
}| @@ -59,7 +91,15 @@ private static List<BidderBid> bidsFromResponse(BidResponse bidResponse) { | |||
| .map(SeatBid::getBid) | |||
| .filter(Objects::nonNull) | |||
| .flatMap(Collection::stream) | |||
| .map(bid -> BidderBid.of(bid, BidType.banner, bidResponse.getCur())) | |||
| .map(bid -> BidderBid.of(bid, getBidType(bid.getMtype()), bidResponse.getCur())) | |||
There was a problem hiding this comment.
the following is not ported
func getBidVideo(bidType openrtb_ext.BidType, bid *openrtb2.Bid) *openrtb_ext.ExtBidPrebidVideo {
if bidType != openrtb_ext.BidTypeVideo {
return nil
}
var primaryCategory string
if len(bid.Cat) > 0 {
primaryCategory = bid.Cat[0]
}
return &openrtb_ext.ExtBidPrebidVideo{
Duration: int(bid.Dur),
PrimaryCategory: primaryCategory,
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#3770