Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vs2010+] Handle compileas for files with "unknown" extensions. #2195

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Mar 22, 2024

What does this PR do?

Handle compileas for files with "unknown"/mismatching_categories extensions for vs* generator.

How does this PR change Premake's behavior?

Only vs* generators impacted.

Anything else we should know?

Tested with https://github.com/Jarod42/premake-sample-projects/tree/vs_compileas/projects/project-compileas
with action: https://github.com/Jarod42/premake-sample-projects/actions/runs/8392851053

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@samsinsane samsinsane merged commit d1f2f0a into premake:master Mar 23, 2024
12 checks passed
@Jarod42 Jarod42 deleted the vs_compileas branch March 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants