Added API for Action Deprecation #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickclark2016
force-pushed
the
feature/action-deprecation
branch
from
84951ae to
8bb74e0
Compare
tritao
approved these changes
Dec 4, 2024
samsinsane
requested changes
Dec 5, 2024
src/base/action.lua
Outdated
Comment on lines
83
to
94
| for key, value in pairs(act.deprecatedaliases) do | ||
| action._deprecatedaliases[key] = value | ||
| end |
There was a problem hiding this comment.
I think this needs to do one of two things; either automatically register deprecated aliases so they can be specified without the aliases table, or, emit a warning/error when the deprecated alias isn't in the aliases table.
My vote is for the auto registration because it's easier to work with.
There was a problem hiding this comment.
I think I'm going to go with both a notify and patching it into the table.
nickclark2016
force-pushed
the
feature/action-deprecation
branch
from
8bb74e0 to
076a4f0
Compare
samsinsane
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds an API for action deprecation. This is in preparation for the official deprecation of gmake.
How does this PR change Premake's behavior?
No breaking changes with this PR. This will be as a stepping stone to introduce breaking changes to actions later.
Anything else we should know?
N/A
Did you check all the boxes?
Add unit tests showing fix or feature works; all tests passNo existing action tests existcloses #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!