Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore update command does not update the document #10

Closed
bettinatop22 opened this issue Jan 29, 2019 · 1 comment
Closed

Firestore update command does not update the document #10

bettinatop22 opened this issue Jan 29, 2019 · 1 comment

Comments

@bettinatop22
Copy link
Contributor

Hello,

when I try to update a document in firestore it's not updated and an error occurs with the following message:

update() requires either a single javascript object or an alternating list of field/value pairs

This is probably due to the fact that the data for update is not passed in the corresponding command:

return `${FIREBASE_EXTRA_PATH} firestore ${action} ${actionPath}`;

I tested it locally by passing the fixturePath as a third argument and it seems to be working as expected.

Let me know what you think. I'd happily submit a fix for this.

Thanks,
Bettina

@prescottprue prescottprue mentioned this issue Feb 1, 2019
prescottprue added a commit that referenced this issue Feb 2, 2019
* fix(logout): remove returning of promise (handled by Cypress) - #9
* fix(callFirestore): support calling `update` by passing data - #10, #11 - @bettinatop22
* feat(docs): add full example for `callFirestore` - #7, #8 - @axacheng
@prescottprue
Copy link
Owner

Fix released in v0.1.1 release, thanks for reporting and providing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants