Fix Required Fields #241
Merged
Fix Required Fields #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,18 @@ | |||
| <script src="jquery-1.5.1.min.js"></script> | |||
| <script src="freezeheader.js"></script> | |||
| <script src="chart.js"></script> | |||
| <script> | |||
| function isRowEmpty(parentNode) { | |||
There was a problem hiding this comment.
This should probably go in chart.js
There was a problem hiding this comment.
Actually, can we do this in pebble instead of in JS? It would fit better with our current programming model that way, and I think it would be more performant.
There was a problem hiding this comment.
@capnfabs I tried but pebble worn me out. There is a bug regarding variable scope in pebble and that's why I choose this solution. We really need to revome pebble as soon as possible.
There was a problem hiding this comment.
@capnfabs Trust me, that wasn't my first option.
|
👍 ready to merge |
llvasconcellos
added a commit
that referenced
this pull request
Jan 25, 2016
…quired-fields Fix Required Fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #89
Needs to merge server side as well:
projectbuendia/buendia#70