Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: namespace metadata sync on creation #1378 #1379

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CharlieR-o-o-t
Copy link
Contributor

Closes #1378

Sync metadata on namespace creation

Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit fd83079
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/67c95b18f7cd4000087b3610

@oliverbaehler
Copy link
Collaborator

Hey until the new implementation is done i am happy to consider this one, could you adsd one e2e test?

@CharlieR-o-o-t CharlieR-o-o-t force-pushed the main branch 6 times, most recently from 2100c2d to f900474 Compare March 5, 2025 23:58
@CharlieR-o-o-t
Copy link
Contributor Author

CharlieR-o-o-t commented Mar 6, 2025

Hello @oliverbaehler
Apologies for the delay, was on vacation.

At first look, I thought this change would be a quick 5-minute adventure. But soon I have realized that all mutation changes need to be handled in a single place. This PR will guarantee consistent namespace metadata on creation/reconcile.

I have also added e2e for both webhook and controller namespace reconcile.

Additionally, I encountered issues with the Harpoon image:
ghcr.io/alegrey91/harpoon:latest is a broken build—there is no execute bit set on the binary, causing the container to crash during trace-e2e. As a workaround, I switched Harpoon back to Docker Hub.

Please take a look when you'll have time.
pipeline should be ok this time.

@CharlieR-o-o-t
Copy link
Contributor Author

/retest

@CharlieR-o-o-t
Copy link
Contributor Author

Have no failed test in trace-e2e on my ubuntu workstation.
Doesn't look like related to my change. Will figure out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync namespace metadata on creation.
2 participants