Sources memory improvement #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've removed the urlscan source, as they just announced official support of API, so we can add again using official API, Can you rebase this PR with master and confirm if this is ready to merge? @vzamanillo |
ehsandeep
added
the
Status: Review Needed
|
@vzamanillo this PR looks good to me, however before merging could you please squash all the commits into one since their number is quite high. Thanks! |
ehsandeep
added
Status: Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279
This branch comes from the same branch of #278 (commit 34fb96f)
I leave the pull request here to not to lose the local changes, we should merge it after the mentioned pull request we could also put it as a draft to release it after.
Main changes:
Decodes
JSONinstead of reading all the response content into memory and parsing withregex:bufferovercertspotteroldcrtshthreatcrowdthreatminerRead responses using
bufioinstead ofioutil.ReadAllgithubcommoncrawlhackertargetwaybackarchiveFixes triple URL encoding:
commoncrawlwaybackarchiveCheck it and tell me what you think!