Minor fixes on simple-app example + extra translation #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for your PR! Can you please rebase it on top of #120? I expect to land it tomorrow into master. |
|
This has now been merged to master. Can you rebase on top of master pls? |
added 2 commits
July 24, 2019 22:40
Also fixed wrong message path and typos in README and simple-app.rs
|
Hi! It's done 😃 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛
fluent-bundledirectory missing in resources directory path🐛 wrong message path for input parse error
✨ french translation of simple-app example
🎨 removed useless turbofish
✏️ fixed some typos in documentation