Don't mark blocks as invalid on context deadlines #14838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
dont_mark_invalid_on_context_deadlines
branch
from
0935b35 to
365c245
Compare
When processing state transition, if the error is because of a context deadline, do not mark it as invalid.
potuz
force-pushed
the
dont_mark_invalid_on_context_deadlines
branch
from
365c245 to
5d9c3d6
Compare
terencechain
requested changes
Jan 29, 2025
There was a problem hiding this comment.
we dont mark the block as invalid due to context error, it's being handle on the cache level. I think it's better to handle this on the cache level...
prysm/beacon-chain/sync/validate_beacon_blocks.go
Lines 413 to 415 in bc69ab8
| @@ -468,6 +468,9 @@ func (s *Service) validateStateTransition(ctx context.Context, preState state.Be | |||
| stateTransitionStartTime := time.Now() | |||
| postState, err := transition.ExecuteStateTransition(ctx, preState, signed) | |||
| if err != nil { | |||
| if ctx.Err() == context.DeadlineExceeded { | |||
There was a problem hiding this comment.
Why not handle this for all context error? is deadline the only one? what about timeout?
terencechain
previously approved these changes
Jan 29, 2025
james-prysm
reviewed
Jan 29, 2025
| @@ -468,6 +468,9 @@ func (s *Service) validateStateTransition(ctx context.Context, preState state.Be | |||
| stateTransitionStartTime := time.Now() | |||
| postState, err := transition.ExecuteStateTransition(ctx, preState, signed) | |||
| if err != nil { | |||
| if ctx.Err() != nil { | |||
| return nil, err | |||
There was a problem hiding this comment.
do we not need a log or error wrapper for context?
There was a problem hiding this comment.
it will be logged by the p2p package.
|
you need to add a changelog |
prestonvanloon
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing state transition, if the error is because of a context deadline, do not mark it as invalid.