Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nlohmann JSON is not found although present, build fails (macOS, homebrew) #2

Closed
cpowell opened this issue Dec 17, 2024 · 2 comments
Closed

Comments

@cpowell
Copy link

cpowell commented Dec 17, 2024

While trying to compile the template according to the instructions on macos 15.1 and 15.2 (both tested), around 65% the following error is produced:

/Users/chris/Desktop/imgui_bundle_template/build/_deps/imgui_bundle-src/external/immvision/immvision/src/immvision/internal/image_params_serialize.cpp:4:10: fatal error: 'nlohmann/json.hpp' file not found

...then soon after this the build fails with make: *** [all] Error 2

nlohmann-json is installed via Homebrew:

==> nlohmann-json: stable 3.11.3 (bottled), HEAD
JSON for modern C++
https://github.com/nlohmann/json
Installed

And it does seem to be found by the preliminary build process:

nlohmann_json: Found via find_package(nlohmann_json)

pthom added a commit to pthom/imgui_bundle that referenced this issue Dec 17, 2024
@pthom
Copy link
Owner

pthom commented Dec 17, 2024

Hi,

This is fixed in pthom/imgui_bundle@e9cdfb1

You might have to remove and recreate your build folder if imgui_bundle had been populated by cmake.
If you are using a git clone for imgui_bundle, please update it beforehand.

@pthom pthom closed this as completed Dec 17, 2024
@cpowell
Copy link
Author

cpowell commented Dec 17, 2024

Confirmed, build completes successfully now,. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants