Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust date of comments that are changed to answers on /questions #2099

Closed
steviepubliclab opened this issue Jan 24, 2018 · 7 comments
Closed
Assignees
Labels
enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute Ruby

Comments

@steviepubliclab
Copy link
Contributor

A new feature was added that allows people to move comments on /questions to answers. However, when comments are now adjusted, a new email goes out and the date of the original post is not maintained.

Here's a link to the code:

@answer = Answer.new(
nid: @comment.nid,
uid: @comment.uid,
content: @comment.comment

@jywarren
Copy link
Member

Let's work on ensuring the dates are set to the original comment date first.

Then, we can suppress the emails by removing this line:

@answer.answer_notify(current_user)

Thanks, @steviepubliclab !!

@jywarren jywarren added enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Jan 24, 2018
@grvsachdeva
Copy link
Member

Hi @steviepubliclab, I have implemented this feature so I am well familiar with the code.Can I help to resolve this? Thanks.

@jywarren
Copy link
Member

jywarren commented Feb 4, 2018

@Gauravano yes please, that would be fantastic!!

@grvsachdeva
Copy link
Member

Thanks, @jywarren .Actually @jywarren @steviepubliclab I have a suggestion regarding email like we have an email for a new answer, comment.etc. Can we make notification mail for this feature too?

@jywarren
Copy link
Member

jywarren commented Feb 5, 2018 via email

@grvsachdeva
Copy link
Member

I am definitely interested in taking this one.Thanks, Jeff.

@jywarren
Copy link
Member

jywarren commented Feb 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Development

No branches or pull requests

3 participants