-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework API to use Solr when available #1366
Conversation
Generated by 🚫 Danger |
That looks great! Is this a pull-request into a pull-request? Wow. I don't know how it works, should I merge this into fix_solr? Great work! |
It is, yes -- to keep this follow-up work separate and sequential, let's wait until #1176 is complete before looking at merging this in. I want to know that the Solr toggling fallback system works on branch1 first! |
Well currently the last push is running already from http://branch1.laboratoriopublico.org - shall I stop Solr in pad.publiclab.org and see what happens? |
yes, please do! so eager! |
Earlier this morning, after loading a fresh SQL dump, I went for reindexing and it's still going, reaally slooow. The good news is that I ran it before Solr was ready and it successfully retried until it was online.
This is not the speed it reindexed the last time. I'm seeing the Solr logs over at pad.publiclab.org and finding it like this:
So that's many tests per seconds (possibly one per record)? Perhaps it would be good to throttle these tests so that there won't be more than one per few seconds or so? |
…it before merge to master)
OK, rebased here too. |
315fe76
to
62e66be
Compare
Needs now to be done on top of (after) #1386 -- could redo this manually, actually.
@icarito - check this change out -- it would make API node searches draw upon Solr when available, and ActiveRecord when not. If you like it, and #1176 is ready, you can merge this into the
fix_solr
branch.Jeff's remaining to-do list:
Node.search
(fulltext) inside ofSearchService
and test it (onSearchService
unit test and JSON API output, & https://publiclab.org/search/dynamic/)