Remove export of silly OpenSSL functions

[richsalz]

It would be nice if you removed use of

• X509_get_default_cert_dir_env as it just returns the value "SSL_CERT_DIR"
• X509_get_default_cert_dir_env as it just returns the value "SSL_CERT_FILE"

Those values are documented in man7/openssl-env.

[alex]

What's the motivation for this?

pyOpenSSL makes use of these, so we can't simply remove them, we'd have to remove the callers there and do a release cycle.

Do all OpenSSL forks document the same guarantees?

Assuming yes, I'm happy to take a PR for this (starting with the pyOpenSSL side), but I don't think any of the maintainers are likely to make time for it.

[reaperhulk]

I’m happy to make time to review, but won’t author the PRs (assuming the forks we support all make the same guarantees)

[richsalz]

Yes LibreSSL and BoringSSL do the same thing, inherited from the original indirection in OpenSSL. I'll make a PR at some point, thanks.

[github-actions]

This issue has been waiting for a reporter response for 3 days. It will be auto-closed if no activity occurs in the next 5 days.

[richsalz]

Close if you want, a couple of silly needless functions won't really hurt the ecosystem. But I will try to do something.

[reaperhulk]

That’s just the automated bot which isn’t very smart. We remain happy to review the PRs.

[alex]

pyca/pyopenssl#1414 removes the usage from pyOpenSSL. Once that's in a release we can remove from here.

[richsalz]

Thanks, I never got around to it (obviously) and decided it wasn't worth anyone working on it :). I appreciate it!