Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PKCS#7 types to GATs #12037

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Convert PKCS#7 types to GATs #12037

wants to merge 1 commit into from

Conversation

alex
Copy link
Member

@alex alex commented Nov 26, 2024

This does not currently work because rust-asn1 doesn't handle Asn1Definedby{Readable,Writable} correctly

@reaperhulk reaperhulk requested a review from Copilot January 31, 2025 23:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

src/rust/cryptography-x509/src/pkcs7.rs:14

  • [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct ContentInfo<'a, Op: Asn1Operation> {

src/rust/cryptography-x509/src/pkcs7.rs:22

  • [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub enum Content<'a, Op: Asn1Operation> {

src/rust/cryptography-x509/src/pkcs7.rs:34

  • [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct SignedData<'a, Op: Asn1Operation> {

src/rust/cryptography-x509/src/pkcs7.rs:64

  • [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct EnvelopedData<'a, Op: Asn1Operation> {
This does not currently work because rust-asn1 doesn't handle Asn1Definedby{Readable,Writable} correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants