Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wheel by bumping STB version #1272

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix wheel by bumping STB version #1272

merged 1 commit into from
Mar 29, 2023

Conversation

dlqqq
Copy link
Contributor

@dlqqq dlqqq commented Mar 27, 2023

Description

See #1253

This PR upgrades the version of STB (build backend used by this project) to the latest release, which includes my PR that fixes the RECORD hashes in built wheels. This will allow Poetry projects to install pydata-sphinx-theme.

Verification

Add this script (validate_wheel.py) to the project root:

import os
from installer.sources import WheelFile

WHEEL_RELPATH = 'dist/pydata_sphinx_theme-0.13.2.dev0-py3-none-any.whl'

wheel_abspath = os.path.join(os.path.dirname(__file__), WHEEL_RELPATH)

with WheelFile.open(wheel_abspath) as source:
    source.validate_record()

Then, build the wheel and verify the script does not except:

$ python -m build
$ python validate_wheel.py

Next steps

Cut a release after this is merged to update the published wheel on PyPi. Then we can close the issue.

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 27, 2023

cc @drammock

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 27, 2023

The new release version should be either 0.13.2 or 0.14.0, depending on what PRs were merged before between 0.13.1 and now.

@12rambau 12rambau merged commit 03503c7 into pydata:main Mar 29, 2023
@dlqqq dlqqq deleted the fix-wheel branch March 29, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants