Fix used-before-assignment for variable annotations guarded by TYPE_CHECKING

[jacobtylerwalls]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #7609

This part of the (terribly long) method is starting to get ugly, so if we merge this first and backport it, I could use #7806 to factor out a staticmethod.

[Pierre-Sassoulas]

if we merge this first and backport it, I could use #7806 to factor out a staticmethod.

We could also release 2.16.0 with the refactor so backports are easier to do after that (we're starting to have a lot of conflict in cherry-pick). There's a lot of content in 2.16.0 already, and we could make 2.17.0 the last minor of the 2.x series after all.

[coveralls]

Pull Request Test Coverage Report for Build 3514404778

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.0002%) to 95.428%

---

Totals
Change from base Build 3512582852:	0.0002%
Covered Lines:	17472
Relevant Lines:	18309

---

💛 - Coveralls

[Pierre-Sassoulas]

I think the branch need to be rebased on latest main for the primer to be usable.

[jacobtylerwalls]

Happy to do it, but the primer result looks correct -- we're fixing that many false positives.

[clavedeluna]

woah all the FP cleared by the primer

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on pytest:
The following messages are no longer emitted:

1. used-before-assignment:
   Using variable 'Literal' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/reports.py#L325
2. used-before-assignment:
   Using variable 'Cache' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/stepwise.py#L61
3. used-before-assignment:
   Using variable 'Literal' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/python.py#L1443
4. used-before-assignment:
   Using variable 'CallSpec2' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/fixtures.py#L246
5. used-before-assignment:
   Using variable 'Deque' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/fixtures.py#L275
6. used-before-assignment:
   Using variable 'Session' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/fixtures.py#L711
7. used-before-assignment:
   Using variable 'Session' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/terminal.py#L326
8. used-before-assignment:
   Using variable 'Session' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/nodes.py#L211
9. used-before-assignment:
   Using variable 'CaptureManager' before assignment
   https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/debugging.py#L244
10. used-before-assignment:
    Using variable 'Literal' before assignment
    https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/runner.py#L376
11. used-before-assignment:
    Using variable 'TerminalReporter' before assignment
    https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/config/__init__.py#L1049
12. used-before-assignment:
    Using variable '_TracebackStyle' before assignment
    https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/config/__init__.py#L1086
13. used-before-assignment:
    Using variable 'Item' before assignment
    https://github.com/pytest-dev/pytest/blob/791b51d0faea365aa9474bb83f9cd964fe265c21/src/_pytest/mark/__init__.py#L228

This comment was generated for commit 14cd577

[Pierre-Sassoulas]

LGTM. Sorry, you fixed so much false positives it looked like a bug 😄

[Pierre-Sassoulas]

Require #7804 to be reviewed and merged in main first becuase I want to backport automatically..

[github-actions]

The backport to maintenance/2.15.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7810-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e2ef840528de633fdf8b826a9d7068345d8f371f
# Push it to GitHub
git push --set-upstream origin backport-7810-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x

Then, create a pull request where the base branch is maintenance/2.15.x and the compare/head branch is backport-7810-to-maintenance/2.15.x.

[Pierre-Sassoulas]

@cdce8p it seems we do need the content: write because this job failed during the push to the backporting branch with:

   /usr/bin/git push --set-upstream origin backport-7810-to-maintenance/2.15.x
  remote: Permission to PyCQA/pylint.git denied to github-actions[bot].
  fatal: unable to access 'https://github.com/PyCQA/pylint.git/': The requested URL returned error: 403
  Error: Error: The process '/usr/bin/git' failed with exit code 128