Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop 2.6 support? #126

Closed
njsmith opened this issue Nov 21, 2017 · 10 comments · Fixed by #127
Closed

drop 2.6 support? #126

njsmith opened this issue Nov 21, 2017 · 10 comments · Fixed by #127

Comments

@njsmith
Copy link
Member

njsmith commented Nov 21, 2017

Apparently the last rebuild broke 2.6 support, because it picked up the latest version of pip, and the latest version of pip dropped 2.6 support: #125

(Or something like that, I haven't looked in detail.)

Should we fix it, or drop 2.6 support entirely? Right now I guess we're building and shipping a 2.6 build that doesn't actually work...

Relevant post from 2.5 years ago: http://www.curiousefficiency.org/posts/2015/04/stop-supporting-python26.html

CC @matthew-brett

@jamadden
Copy link
Member

gevent dropped 2.6 support a year ago, so we no longer need manylinux to support it. The same goes for other libs with C extensions I work on like zope.interface.

@rdb
Copy link
Contributor

rdb commented Nov 21, 2017

For what it's worth, I can confirm we have no compelling reason to support 2.6 either. Python 2.6 stopped being maintained in 2013, and given that pip, wheel and setuptools finally dropped 2.6 support, continuing to support it in manylinux seems like a pointless endeavour.

njsmith added a commit to njsmith/manylinux that referenced this issue Nov 24, 2017
It's broken because pip and setuptools have dropped support, and
no-one seems to be bothered or care about fixing it, so let's do this.

Closes pypa#126
dvarrazzo added a commit to psycopg/psycopg2-wheels that referenced this issue Nov 28, 2017
wheel 0.30.0 dropped support for Py2 <= 2.6, Py3 <= 3.3, see
https://pypi.python.org/pypi/wheel

Also see pypa/manylinux#126
@dvarrazzo
Copy link

Psycopg 2.7.x still support Python 2.6. Because psycopg release policy follows semver, we are not planning to drop Python 2.6 support until Psycopg 2.8. So please allow a way to install a manylinux image which can still support Python 2.6 (a Docker tag, whatever).

Also note that wheel 0.30 also dropped support for Python 3.2 and 3.3: they appear to be still working, as far as Psycopg is concerned, but this is possibly just luck. I suggest to build the image using wheel<0.30 for the above Python versions.

@njsmith
Copy link
Member Author

njsmith commented Nov 28, 2017

@dvarrazzo when is psycopg 2.8 expected to release? (Or maybe what I really mean is: when do you plan to drop support for psycopg 2.7.x?)

The manylinux images don't currently support Python 3.2. I guess we could consider dropping 3.3 at some point too -- my guess is it has substantially lower usage than 2.6, though I haven't checked...

@hugovk
Copy link
Contributor

hugovk commented Nov 28, 2017

I'd like to suggest Psycopg drop Python 2.6 sooner rather than later (eg. the next release). Python 2.6 hasn't received security updates in 4 years, and many other libraries have already dropped it, with more in the process, making it harder to support (as you've discovered with wheel), and some are already planning on dropping 2.7 in mid-2018.

Here's the pip installs for psycopg2 from PyPI for the last month (via pypinfo --percent --pip psycopg2 pyversion), showing a very small fraction for 2.6.

python_version percent download_count
2.7 66.3% 1,204,104
3.6 16.2% 295,175
3.5 10.5% 190,975
3.4 6.0% 108,275
2.6 0.8% 15,099
3.7 0.1% 1,774
3.3 0.1% 1,147
3.2 0.0% 25
None 0.0% 21

I've opened an issue here: psycopg/psycopg2#626.

@dvarrazzo
Copy link

@njsmith I don't say to keep on supporting 2.6: I just say leave open the possibility to use an older image to build it.

We don't have a scheduled date to release 2.8. If the wheel infrastructure won't be available anymore before that time we will simply drop 2.6 wheels in some Psycopg 2.7.x. I'm not overly fussed with 2.6 wheels, no (psycopg wheels are recent, less than 1 year old: I doubt anyone relies on them while requiring Python 2.6...)

I just expect, because it's the most natural thing in the world, that manylinux images provide some form of semantic versioning to identify the supported features... no?

@hugovk
Copy link
Contributor

hugovk commented Nov 30, 2017

Note: psycopg2 has dropped support for EOL Pythons 2.6 and 3.3 (psycopg/psycopg2#628).

@ghost
Copy link

ghost commented Nov 30, 2017

Guys, would it be OK for multibuild to drop Python 2.6?

@dvarrazzo
Copy link

dvarrazzo commented Nov 30, 2017 via email

@ghost
Copy link

ghost commented Nov 30, 2017

I'm pretty sure that #127 would make life impossible. Actually, life may already be impossible given that the 2.6 image appears to be currently broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants