Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.11 to CI #11550

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Add 3.11 to CI #11550

merged 2 commits into from
Oct 28, 2022

Conversation

uranusjr
Copy link
Member

Let’s see

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 26, 2022
@uranusjr
Copy link
Member Author

uranusjr commented Oct 26, 2022

This is officially not working. Need to finish #11288. Now this can work.

@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Oct 27, 2022
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Oct 27, 2022
@uranusjr uranusjr changed the title Try adding 3.11 to CI Add 3.11 to CI Oct 27, 2022
Also upgrade checkout to v3 and setup-python to v4.

Signed-off-by: Henry Schreiner <[email protected]>
@uranusjr uranusjr marked this pull request as ready for review October 27, 2022 18:52
@uranusjr uranusjr force-pushed the 3.11 branch 2 times, most recently from 9886746 to 0002b64 Compare October 28, 2022 05:56
We switched the metadata backend to importlib.metadata for Python 3.11
onwards, which normalizes path differently.

There are two tests about this, but since we've switched to the new
resolver now they do exactly the same thing and can be merged.
@uranusjr
Copy link
Member Author

While fixing test failures due to changing from pkg_resources to importlib.metadata I deleted a test that is redundant now we’ve switched to the new resolver.

@pradyunsg pradyunsg merged commit d6e333f into pypa:main Oct 28, 2022
@pradyunsg
Copy link
Member

Thanks for taking this over the line @uranusjr! ^>^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants