Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.2 #3156

Merged
merged 1 commit into from
Oct 1, 2015
Merged

Drop support for Python 3.2 #3156

merged 1 commit into from
Oct 1, 2015

Conversation

dstufft
Copy link
Member

@dstufft dstufft commented Oct 1, 2015

Pending discussion on pypa-dev.

@dstufft dstufft force-pushed the drop-32 branch 2 times, most recently from efb3aaf to 986ae82 Compare October 1, 2015 13:20
@xavfernandez
Copy link
Member


Python 2.5 was supported through v1.3.1, and Python 2.4 was supported through
v1.1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information seems useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We weren't keeping it up to date (for instance, it didn't include Python 3.1 being dropped) and it's sort of a pain (for instance, right now I'd say "Python 3.2 was supported through 7.1.2", but if we release 7.1.3 then this needs updated). It also duplicates information that is already available in the change log.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'd prefer to keep this, and add that 3.2 was supported through v7. That way we have a record of what version people on older Pythons should use.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfmoore Any reason that the record in CHANGES.txt is not sufficient?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstufft your comment came in while mine was being typed. That's a fair point. Maybe we just modify it to be a list of "support for Python X.Y was dropped in version Z"?

But agreed it's a bit of a pain. Happy for you to simply drop it and if I get the time I can trawl the changelogs and add back in a simpler summary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason that the record in CHANGES.txt is not sufficient?

Stop typing while I am! :-) Simply that here is a little more visible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop typing while I am! :-)

NO U

:D

@dstufft
Copy link
Member Author

dstufft commented Oct 1, 2015

Good catch on missing the reference to 3.2 in .travis/run.sh.

@dstufft
Copy link
Member Author

dstufft commented Oct 1, 2015

Gonna merge this, if anyone has complaints we can revert.

dstufft added a commit that referenced this pull request Oct 1, 2015
Drop support for Python 3.2
@dstufft dstufft merged commit 5a15cbb into pypa:develop Oct 1, 2015
@dstufft dstufft deleted the drop-32 branch October 1, 2015 18:43
@yan12125
Copy link
Contributor

An question: is there a chance to apply this commit in progress into _vendor, so that pip works on Python 3.2 again? Or I have to stick with pip < 8 for Python 3.2 support?

@RonnyPfannschmidt
Copy link
Contributor

python 3.2 is not only end of life, but also has a considerable maintenance burden

pip intensely wants to avoid patching vendored libs, we want them unmodified

@yan12125
Copy link
Contributor

pip works on Python 3.2 again?

So the answer is no?

python 3.2 is not only end of life

The 3.2 branch on CPython HG is not closed yet, and the 3.2 version tag is available on bugs.python.org, too. In fact I have posted a question to python-dev but got no response yet.

@pfmoore
Copy link
Member

pfmoore commented Jun 11, 2016

Correct, the answer is no.

Python 3.2 was in security fix mode until February 2016, but is now end of life. See https://docs.python.org/devguide/devcycle.html#summary - we don't remove old tags, so the fact that a tag is present means nothing.

@pfmoore
Copy link
Member

pfmoore commented Jun 11, 2016

You do of course have the option of applying the patch you mention to a local copy of pip, and maintaining that for yourself for however long you wish. It's just that pip itself won't apply that patch.

@yan12125
Copy link
Contributor

Thanks. Existing Python 3.2 stuff as well as the delayed (or cancelled?) 3.2.7 release is quite confusing on deciding whether to support Python 3.2 or not.

@Ivoz
Copy link
Contributor

Ivoz commented Jun 15, 2016

@yan12125 if that commit is present in a future ( / current) pypi release of the progress package, then pip will likely eventually incorporate it when we update vendor libraries to their latest stable releases. What we don't do is manually include patches to the libraries under _vendor.

So you may find a future >=8.x release of pip works on python 3.2, purely incidentally (if this was the only 3.2 incompatability) - however absolutely no expectations should be made.

@yan12125
Copy link
Contributor

Thanks for the detailed explanation and never mind. I've proposed to drop Python 3.2 support in our application.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants