Provenance retrieval route #16778
Merged
Provenance retrieval route #16778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest PEP 740 language doesn't include this, so we don't need it. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
11 tasks
di
reviewed
Sep 23, 2024
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Sep 24, 2024
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Sep 26, 2024
woodruffw
commented
Sep 26, 2024
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
di
approved these changes
Sep 26, 2024
This was referenced Sep 27, 2024
miketheman
reviewed
Oct 2, 2024
|
|
||
|
|
||
| def _select_content_type(request: Request) -> str: | ||
| offers = request.accept.acceptable_offers( |
There was a problem hiding this comment.
thought: unrelated to this change, I wonder if this pattern is relatively easy to replace with our use of deprecated .best_match
Co-authored-by: Mike Fiedler <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
miketheman
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, not ready for review yet.This hastwothree functional changes:Provenance.provenance_digest, since the latest PEP 740 language doesn't include it/_/provenance/{filename}/) for retrieving a file's provenance, if it existsThat route will be accessible, but isn't linked to any of the index representations in this PR. I'll do that with the final PR, which will be built off of #16624.
Signed-off-by: William Woodruff [email protected]