-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provenance retrieval route #16778
Provenance retrieval route #16778
Conversation
The latest PEP 740 language doesn't include this, so we don't need it. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't super familiar with this, so it took me a bit longer than I expected, but maybe that's a good thing!
I left in a bunch of notes, let me know if anything doesn't make sense.
|
||
|
||
def _select_content_type(request: Request) -> str: | ||
offers = request.accept.acceptable_offers( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: unrelated to this change, I wonder if this pattern is relatively easy to replace with our use of deprecated .best_match
Co-authored-by: Mike Fiedler <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
WIP, not ready for review yet.This hastwothree functional changes:Provenance.provenance_digest
, since the latest PEP 740 language doesn't include it/_/provenance/{filename}/
) for retrieving a file's provenance, if it existsThat route will be accessible, but isn't linked to any of the index representations in this PR. I'll do that with the final PR, which will be built off of #16624.
Signed-off-by: William Woodruff [email protected]