remove hardcoded saferepr limit #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
requested changes
Oct 25, 2017
| @@ -56,7 +56,7 @@ def _callhelper(self, call, x, *args): | |||
| s = s[:i] + '...' + s[len(s)-j:] | |||
| return s | |||
|
|
|||
| def saferepr(obj, maxsize=240): | |||
| def saferepr(obj, maxsize=240,maxother=160, maxarray=6, maxdict=4): | |||
There was a problem hiding this comment.
a space is missing here
| srepr.maxsize = srepr.maxlong = maxsize | ||
| srepr.maxother = maxother | ||
| srepr.maxdict = maxdict | ||
| srepr.maxlist = srepr.maxarray = srepr.maxset = srepr.maxmaxfrozenset = srepr.maxdeque = srepr.maxtuple = maxarray |
There was a problem hiding this comment.
i believe maxmaxfrozenset is a c&p mistake
|
This would be very helpful for my team, as well. In our case, we're getting bitten by truncation in the asserts on lists. Anything I can do to help his one along as it looks to have stalled here? |
|
@dimaspivak since @ApaDoctor doesnt seem to responds and its a simple one, its perhaps easiest to redo the pr |
|
closing as no longer responsive, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Py has hardcoded limit of saferepr.
This PR fixes that.