Use setup/teardown from Django (TransactionTestCase) #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
changed the title
blueyed
force-pushed
the
use-django-transactiontestcase
branch
from
3fb43bd to
d594738
Compare
blueyed
force-pushed
the
use-django-transactiontestcase
branch
from
d594738 to
846e130
Compare
…lper Let's see where this blows up.
blueyed
force-pushed
the
use-django-transactiontestcase
branch
from
846e130 to
621c4a9
Compare
|
This looks very good, using TransactionTestCase directly is much better than doing the flushing by ourselves. Is there any need for new tests for this? Shouldn't the existing tests for transactional tests should be enough? |
I'm not sure if the existing tests are specific enough, but this can be improved / fixed when any issues are being reported from this. I'll merge it for now. |
blueyed
changed the title
mfa
pushed a commit
to aexeagmbh/pytest-django
that referenced
this pull request
May 17, 2017
beyondgeeks
pushed a commit
to beyondgeeks/django-pytest
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
_pre_setupand_post_teardownfrom Django also forTransactionTestCase.This would provide additional features, and makes the behavior more consistent.
It does not work with Django < 1.5 however, which is now special-cased.
I'm going to add some test(s) for the new behavior later.