Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve source positions for assertion rewriting #12815

Merged
merged 1 commit into from
Oct 9, 2024
Merged

preserve source positions for assertion rewriting #12815

merged 1 commit into from
Oct 9, 2024

Conversation

15r10nk
Copy link
Contributor

@15r10nk 15r10nk commented Sep 14, 2024 •
edited
Loading

closes #12818

@15r10nk 15r10nk mentioned this pull request Sep 15, 2024
Closed
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Sep 15, 2024
@15r10nk 15r10nk force-pushed the preserve_positions branch 2 times, most recently from d7aa2d0 to 5412956 Compare September 15, 2024 08:34
@15r10nk 15r10nk marked this pull request as ready for review September 15, 2024 09:06
nicoddemus
nicoddemus requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @15r10nk for the PR, we really appreciate it!

Everything looks reasonable to me, appreciate the extensive tests.

Left a few minor suggestions, otherwise LGTM!

@15r10nk
Copy link
Contributor Author

15r10nk commented Oct 4, 2024

thank you @nicoddemus for the review. I applied your requested changes.

nicoddemus
nicoddemus approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@15r10nk 15r10nk force-pushed the preserve_positions branch from a8cea83 to 5c25c59 Compare October 4, 2024 11:53
@15r10nk
Copy link
Contributor Author

15r10nk commented Oct 4, 2024

I commented it, squashed it and rebased it.

@nicoddemus nicoddemus merged commit fb74025 into pytest-dev:main Oct 9, 2024
29 checks passed
@nicoddemus nicoddemus added the backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch label Oct 9, 2024
@patchback Patchback
Copy link

patchback bot commented Oct 9, 2024 •
edited
Loading

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/fb740251fe1d7facd1f8a341e22d4aa07ba7833c/pr-12815

Backported as #12867

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Oct 9, 2024
Merged
@15r10nk 15r10nk mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assertion rewriting ignores the original source positions
2 participants
@15r10nk @nicoddemus