Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous docstring of pytest.Config #12879

Closed
wants to merge 3 commits into from
Closed

Fix ambiguous docstring of pytest.Config #12879

wants to merge 3 commits into from

Conversation

sus-pe
Copy link
Contributor

@sus-pe sus-pe commented Oct 11, 2024 •
edited
Loading

For context see #10558.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Oct 11, 2024
@sus-pe sus-pe mentioned this pull request Oct 11, 2024
Closed
4 tasks
@sus-pe sus-pe force-pushed the fix-config-docstring-10558 branch 2 times, most recently from 5520309 to 5a37747 Compare October 12, 2024 08:41
@sus-pe sus-pe force-pushed the fix-config-docstring-10558 branch from 5a37747 to 6e0a219 Compare October 12, 2024 08:41
@sus-pe sus-pe marked this pull request as ready for review October 12, 2024 08:42
@sus-pe sus-pe force-pushed the fix-config-docstring-10558 branch from 6e0a219 to 18a9817 Compare October 12, 2024 08:55
@nicoddemus nicoddemus mentioned this pull request Oct 13, 2024
Merged
@nicoddemus
Copy link
Member

Thanks a lot @sus-pe! Really appreciate the extra tests.

I meant to push an additional commit to this PR before merging but did not have permissions to do it, so I opened #12886, which supersedes this one.

Thanks again!

@nicoddemus nicoddemus closed this Oct 13, 2024
@patchback patchback bot mentioned this pull request Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sus-pe @nicoddemus