docs: Create links for objects to show the api #2473
Conversation
| @@ -540,7 +540,7 @@ def add_hookcall_monitoring(self, before, after): | |||
| of HookImpl instances and the keyword arguments for the hook call. | |||
|
|
|||
| ``after(outcome, hook_name, hook_impls, kwargs)`` receives the | |||
| same arguments as ``before`` but also a :py:class:`_CallOutcome`` object | |||
| same arguments as ``before`` but also a :py:class:`_CallOutcome <_pytest.vendored_packages.pluggy._CallOutcome>` object | |||
There was a problem hiding this comment.
This change should be applied in the upstream repository at pytest-dev/pluggy instead.
There was a problem hiding this comment.
the real problem is, that we change the absolute path, there - the whole thing is incorrect unless we stop vendoring
There was a problem hiding this comment.
"the whole thing" you mean the entire PR? I don't think so, only the change in pluggy needs to be dropped, the other links work fine.
There was a problem hiding this comment.
@nicoddemus what i mean is that the pluggy details we include in the docs go wrong because we change the absolute name of everything inside pluggy due to vendoring (so the change to pluggy is correct for the context of making the pytest docs correct, but it breaks vendoring
|
Thanks again @ApaDoctor! |
Fixes: #2331
head-fork: ApaDoctor/pytest
compare: docs-fixes
base-fork: pytest-dev/pytest
base: master # if it's a bugfix