Make YIELD_TEST warning less spammy #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit it only once per each generator, rather than for each generated function. Also add information about which test caused it to be emitted.
|
Updated it to use |
|
@RonnyPfannschmidt would you like to take a look or can we merge this? |
|
Thanks! This is a big help (then just patiently waiting for the release...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit the yield test deprecation warning only once per generator, rather than for each generated function.
This is important when porting old projects with a large number of legacy yield tests --- you don't want to have the warning repeated 10000+ times in the output.
Addresses #2562 (apart from the fact that these warnings cannot be ignored via filterwarnings)