-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show testpaths option in the header if it has been used for collection #4876
Show testpaths option in the header if it has been used for collection #4876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the inverted logic in the changelog this looks good.
53a3d3e
to
b010f07
Compare
Codecov Report
@@ Coverage Diff @@
## features #4876 +/- ##
===========================================
- Coverage 95.76% 92.47% -3.3%
===========================================
Files 113 113
Lines 25744 25239 -505
Branches 2508 2500 -8
===========================================
- Hits 24655 23339 -1316
- Misses 773 1497 +724
- Partials 316 403 +87
Continue to review full report at Codecov.
|
Thanks for the quick review. I've pushed another commit also removing What do you think? |
@@ -1199,15 +1219,6 @@ def test_summary_stats(exp_line, exp_color, stats_arg): | |||
assert color == exp_color | |||
|
|||
|
|||
def test_no_trailing_whitespace_after_inifile_word(testdir): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is now unnecessary, test_header
already covers this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
b010f07
to
0deb7b1
Compare
Fix #4875