Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdb: move/refactor initialization of PytestPdbWrapper #5322

Merged
merged 1 commit into from
May 30, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 28, 2019

No description provided.

@blueyed blueyed added this to the 4.6 milestone May 28, 2019
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #5322 into features will decrease coverage by 7.71%.
The diff coverage is 53.4%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5322      +/-   ##
============================================
- Coverage      92.4%   84.69%   -7.72%     
============================================
  Files           115      115              
  Lines         26294    26307      +13     
  Branches       2597     2600       +3     
============================================
- Hits          24297    22280    -2017     
- Misses         1677     3645    +1968     
- Partials        320      382      +62
Impacted Files Coverage Δ
testing/test_pdb.py 46.51% <33.33%> (-1.05%) ⬇️
src/_pytest/debugging.py 70.25% <54.87%> (-19.59%) ⬇️
testing/test_reports.py 10.49% <0%> (-89.51%) ⬇️
testing/test_session.py 17.72% <0%> (-82.28%) ⬇️
testing/test_unittest.py 23.52% <0%> (-75.57%) ⬇️
testing/test_runner_xunit.py 29.82% <0%> (-70.18%) ⬇️
testing/test_runner.py 34.7% <0%> (-61.61%) ⬇️
src/_pytest/unittest.py 46.31% <0%> (-47.9%) ⬇️
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
testing/test_resultlog.py 53.6% <0%> (-46.4%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10f289...61dfd0a. Read the comment docs.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything else you plan to do here @blueyed?

@blueyed blueyed changed the title WIP: pdb: move/refactor initialization of PytestPdbWrapper pdb: move/refactor initialization of PytestPdbWrapper May 30, 2019
@blueyed
Copy link
Contributor Author

blueyed commented May 30, 2019

@nicoddemus
This might be good/better now, please review.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@blueyed blueyed merged commit d6ce2e5 into pytest-dev:features May 30, 2019
@blueyed blueyed deleted the pdb-wrapper branch May 30, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants