Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable coverage for 'py37' environment" #5396

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 4, 2019

This reverts commit 6d393c5.

It should not be necessary, because we have it via other jobs already.

@blueyed blueyed self-assigned this Jun 4, 2019
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #5396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5396   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files         114      114           
  Lines       25496    25496           
  Branches     2474     2474           
=======================================
  Hits        24473    24473           
  Misses        718      718           
  Partials      305      305

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190456a...d9eafbd. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 5, 2019

Looks like subprocess coverage is not working on Azure.

@blueyed blueyed force-pushed the travis-py37-nocov branch from 3e60123 to 446602d Compare June 5, 2019 01:52
@blueyed
Copy link
Contributor Author

blueyed commented Jun 5, 2019

Should be fixed now.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky sneaky slashes!

@blueyed
Copy link
Contributor Author

blueyed commented Jun 5, 2019

This has still unexpected changes, taken the azure fix out: #5403

This reverts commit 6d393c5.

It should not be necessary, because we have it via other jobs already.
@blueyed blueyed force-pushed the travis-py37-nocov branch from 446602d to d9eafbd Compare June 5, 2019 10:13
@blueyed blueyed merged commit be84ba8 into pytest-dev:master Jun 5, 2019
@blueyed blueyed deleted the travis-py37-nocov branch June 5, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants