Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small mypy fixes #5415

Merged
merged 1 commit into from
Jun 6, 2019
Merged

small mypy fixes #5415

merged 1 commit into from
Jun 6, 2019

Conversation

asottile
Copy link
Member

@asottile asottile commented Jun 6, 2019

mypy is very far from passing, but it did point out a few small cleanups that were doable

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blueyed
Copy link
Contributor

blueyed commented Jun 6, 2019

Great.
Would be nice to have some mypy config already in setup.cfg maybe, or share it here.

@asottile
Copy link
Member Author

asottile commented Jun 6, 2019

agreed, but even with no config there's 1000+ errors right now, I hope to reduce them slowly, eventually

I was using pre-commit try-repo https://github.com/pre-commit/mirrors-mypy and then fixing the crashes

@blueyed
Copy link
Contributor

blueyed commented Jun 6, 2019

mypy --check-untyped-defs --ignore-missing-imports src/ has 275 issues "only".. ;)

@asottile
Copy link
Member Author

asottile commented Jun 6, 2019

I was also looking at testing since it's useful to validate those calls as well, I might've also had --check-untyped-defs as well I forget

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #5415 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5415      +/-   ##
==========================================
+ Coverage   95.98%   95.99%   +<.01%     
==========================================
  Files         114      114              
  Lines       25523    25514       -9     
  Branches     2480     2480              
==========================================
- Hits        24499    24491       -8     
+ Misses        718      717       -1     
  Partials      306      306
Impacted Files Coverage Δ
testing/test_tmpdir.py 98.31% <ø> (-0.01%) ⬇️
src/_pytest/outcomes.py 95.58% <100%> (ø) ⬆️
testing/test_pytester.py 89.33% <100%> (-0.13%) ⬇️
testing/python/raises.py 94.2% <100%> (ø) ⬆️
src/_pytest/assertion/util.py 93.41% <100%> (-0.11%) ⬇️
testing/io/test_saferepr.py 100% <100%> (+2.27%) ⬆️
testing/python/fixtures.py 99.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450d264...ccd87f9. Read the comment docs.

@asottile asottile merged commit 0405697 into pytest-dev:master Jun 6, 2019
@asottile asottile deleted the small_mypy_fixes branch June 6, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants