-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate pytest-faulthandler into the core #5441
Conversation
7d6d931
to
21ec764
Compare
Codecov Report
@@ Coverage Diff @@
## master #5441 +/- ##
==========================================
+ Coverage 96.03% 96.04% +<.01%
==========================================
Files 115 117 +2
Lines 25512 25595 +83
Branches 2480 2486 +6
==========================================
+ Hits 24501 24582 +81
- Misses 706 707 +1
- Partials 305 306 +1
Continue to review full report at Codecov.
|
21ec764
to
6d332c1
Compare
Anymore reviewers? 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the timeout type, this looks good to me.
* Add pytest-faulthandler files unchanged * Adapt imports and tests * Add code to skip registration of the external `pytest_faulthandler` to avoid conflicts Fix pytest-dev#5440
6d332c1
to
a37b902
Compare
* The --no-faulthandler option is not necessary given that we can use `-p no:faulthandler`. * The `--faulthandler-timeout` command-line option has become an ini option, for the reasons described in pytest-dev/pytest-faulthandler#34 and users can still set it from the command-line. Fix pytest-dev/pytest-faulthandler#34
Implemented two small changes in the last commit, with the objective of simplifying the code:
It seems the changes are innocuous and a step in the right direction of having less command-line options when existing options will do. I doubt if this will affect users much too. Let me know if you have any objections, otherwise I plan to merge this soon. 😁 |
pytest_faulthandler
to avoid conflicts
Fix #5440