Fix stepwise crash when first collected module fails #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5446 +/- ##
==========================================
+ Coverage 95.96% 95.98% +0.02%
==========================================
Files 114 114
Lines 25502 25502
Branches 2479 2479
==========================================
+ Hits 24473 24479 +6
+ Misses 723 717 -6
Partials 306 306
Continue to review full report at Codecov.
|
|
Thanks for providing a failing test @graingert! I implemented and pushed a fix. 👍 |
|
(We really should initialize all variables during |
nicoddemus
approved these changes
Jun 13, 2019
graingert
commented
Jun 13, 2019
Since then pytest itself adopted the behavior of interrupting the test session on collection errors, so --sw no longer needs to handle this. The --sw behavior seems have been implemented when pytest would continue execution even if there were collection errors.
nicoddemus
changed the title
nicoddemus
added
the
needs backport
nicoddemus
reviewed
Jun 14, 2019
| @@ -69,12 +70,6 @@ def pytest_collection_modifyitems(self, session, config, items): | |||
|
|
|||
| config.hook.pytest_deselected(items=already_passed) | |||
|
|
|||
| def pytest_collectreport(self, report): | |||
There was a problem hiding this comment.
No longer needed as described in bc345ac.
|
did this one get backported? hard to tell 🤔 |
Merged
|
It was in 4b104ba |
nicoddemus
removed
the
needs backport
|
sweet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5444