Include pytest version in the cached pyc tags #5484
Conversation
| @@ -21,7 +22,7 @@ | |||
| from _pytest.pathlib import PurePath | |||
|
|
|||
| # pytest caches rewritten pycs in __pycache__. | |||
| PYTEST_TAG = "{}-PYTEST".format(sys.implementation.cache_tag) | |||
| PYTEST_TAG = "{}-pytest-{}".format(sys.implementation.cache_tag, version) | |||
There was a problem hiding this comment.
Decided to use lowercase pytest here because all the other tag elements are lower case. Decided to follow suit.
Codecov Report
@@ Coverage Diff @@
## master #5484 +/- ##
==========================================
+ Coverage 96.07% 96.07% +<.01%
==========================================
Files 117 117
Lines 25538 25546 +8
Branches 2473 2473
==========================================
+ Hits 24536 24544 +8
Misses 698 698
Partials 304 304
Continue to review full report at Codecov.
|
|
Btw any concerns about the name of the file containing the dotted pytest version? For example I don't think it should be any problem, but thought I would ask. |
|
Seems fine to me! |
Likely should not really be a problem, but |
|
Though dropping dots creates ambiguity between 5.1.10 and 5.11.0 🤷♂️ |
Had the same thought. Well let's merge this then. |
|
pytest: drop the dot... only sometimes ;) |
All credits go to @asottile! Just wanted to make a small contribution before calling it a day.
Fix #1671