Merge features into master #5491
Conversation
Merge master into features
Disallow abbreviated command-line options
scripts/release.py
Outdated
| @@ -105,7 +105,7 @@ def changelog(version, write_out=False): | |||
|
|
|||
| def main(): | |||
| init(autoreset=True) | |||
| parser = argparse.ArgumentParser() | |||
| parser = argparse.ArgumentParser(allow_abbrev=False) | |||
There was a problem hiding this comment.
idk why we changed this in this file, there's no plugins involved here and prefix matching is actually kind of a nice feature
There was a problem hiding this comment.
See the mentioned issues for the problems that prefix matching brings, namely that we can't know that a prefix matches a given option during preparsing, because later on plugins might register options that actually match the option given by the user.
There was a problem hiding this comment.
Oh but you got a point about changing it in this file, here doesn't really hurt. 😁
There was a problem hiding this comment.
to be clear, I agree with the change in pytest proper, just not in these helper scripts
There was a problem hiding this comment.
Yeah, I understand and agree. 👍
There was a problem hiding this comment.
ok if I add a commit to this PR which undoes those two?
extra/get_issues.py
Outdated
| @@ -74,7 +74,7 @@ def report(issues): | |||
| if __name__ == "__main__": | |||
| import argparse | |||
|
|
|||
| parser = argparse.ArgumentParser("process bitbucket issues") | |||
| parser = argparse.ArgumentParser("process bitbucket issues", allow_abbrev=False) | |||
There was a problem hiding this comment.
Agreed, my bad for not catching this really.
Codecov Report
@@ Coverage Diff @@
## master #5491 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 117 117
Lines 25550 25550
Branches 2473 2473
=======================================
Hits 23962 23962
Misses 1259 1259
Partials 329 329
Continue to review full report at Codecov.
|
|
Merging as the failure is related to tox, which should have been fixed by now with the 3.13.1 release. 👍 |
Didn't realize @Zac-HD's last PR was targeting
features.@Zac-HD we didn't really announce it anywhere (sorry), but we will work only on
masteruntil 5.0 is released, because the py27/py34 support drop happened onmaster.After 5.0 gets released, it is business as usual regarding
master/features. 👍