-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyupgrade docs to Python 3 #5705
Conversation
def pytest_generate_tests(metafunc): | ||
idlist = [] | ||
argvalues = [] | ||
for scenario in metafunc.cls.scenarios: | ||
idlist.append(scenario[0]) | ||
items = scenario[1].items() | ||
argnames = [x[0] for x in items] | ||
argvalues.append(([x[1] for x in items])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might look like a mistake, but it's not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @verhovsky, we appreciate it!
As I mentioned, the implicit code block limiters ::
need to be removed if they are followed by a proper .. code-block:
directive. 👍
Codecov Report
@@ Coverage Diff @@
## master #5705 +/- ##
==========================================
- Coverage 96.16% 96.14% -0.03%
==========================================
Files 117 117
Lines 25864 25864
Branches 2498 2498
==========================================
- Hits 24873 24867 -6
- Misses 690 696 +6
Partials 301 301
Continue to review full report at Codecov.
|
…\n.. code-block")" This reverts commit 9fce0bd.
…":\n\n.. code-block")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
@verhovsky |
ran pyupgrade-docs (it's just a copy of asottile/blacken-docs but with pyupgrade instead) with
--py3-only
then I labeled all the unlabeled code blocks I could find (except the ones in
/doc/en/announce
) as python/text/bash because pyupgrade-docs and blacken-docs don't pick up unlabeledcode-block
sthen I re-ran pyupgrade and also blacken-docs