Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyupgrade docs to Python 3 #5705

Merged
merged 7 commits into from
Aug 7, 2019
Merged

pyupgrade docs to Python 3 #5705

merged 7 commits into from
Aug 7, 2019

Conversation

verhovsky
Copy link
Contributor

@verhovsky verhovsky commented Aug 6, 2019

ran pyupgrade-docs (it's just a copy of asottile/blacken-docs but with pyupgrade instead) with --py3-only

then I labeled all the unlabeled code blocks I could find (except the ones in /doc/en/announce) as python/text/bash because pyupgrade-docs and blacken-docs don't pick up unlabeled code-blocks

then I re-ran pyupgrade and also blacken-docs

@verhovsky verhovsky changed the title clean up docs a bit pyupgrade docs to Python 3 Aug 6, 2019
def pytest_generate_tests(metafunc):
idlist = []
argvalues = []
for scenario in metafunc.cls.scenarios:
idlist.append(scenario[0])
items = scenario[1].items()
argnames = [x[0] for x in items]
argvalues.append(([x[1] for x in items]))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might look like a mistake, but it's not.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @verhovsky, we appreciate it!

As I mentioned, the implicit code block limiters :: need to be removed if they are followed by a proper .. code-block: directive. 👍

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #5705 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5705      +/-   ##
==========================================
- Coverage   96.16%   96.14%   -0.03%     
==========================================
  Files         117      117              
  Lines       25864    25864              
  Branches     2498     2498              
==========================================
- Hits        24873    24867       -6     
- Misses        690      696       +6     
  Partials      301      301
Impacted Files Coverage Δ
src/_pytest/doctest.py 94.38% <0%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c486a...78de9d4. Read the comment docs.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@nicoddemus nicoddemus merged commit 6c8d8a9 into pytest-dev:master Aug 7, 2019
@blueyed
Copy link
Contributor

blueyed commented Aug 8, 2019

@verhovsky
Thanks for the contribution.
For the future it would be better to not have reverted commits, but rather remove them by force-pushing. Also @nicoddemus of course, who could have asked for this / squashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants