Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertrepr_compare: prefer same maxsize #5731

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 12, 2019

Previously it would say:

> assert '123456789012...901234567890A' == '1234567890123...901234567890B'"

This makes it look like the "3" might be different already.

This is clearer, and it is OK to have potentially one less char in the
right one:

> assert '123456789012...901234567890A' == '123456789012...901234567890B'"

Previously it would say:

    > assert '123456789012...901234567890A' == '1234567890123...901234567890B'"

This makes it look like the "3" might be different already.

This is clearer, and it is OK to have potentially one less char in the
right one:

    > assert '123456789012...901234567890A' == '123456789012...901234567890B'"
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #5731 into features will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5731      +/-   ##
============================================
- Coverage     96.25%   96.25%   -0.01%     
============================================
  Files           117      117              
  Lines         25895    25899       +4     
  Branches       2494     2494              
============================================
+ Hits          24926    24929       +3     
- Misses          666      667       +1     
  Partials        303      303
Impacted Files Coverage Δ
src/_pytest/assertion/util.py 95.03% <100%> (ø) ⬆️
testing/test_assertrewrite.py 85.19% <75%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300f785...cb481a3. Read the comment docs.

@nicoddemus
Copy link
Member

We could use a trivial changelog entry I think

@blueyed blueyed merged commit ed24251 into pytest-dev:features Aug 12, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Aug 12, 2019

@nicoddemus

We could use a trivial changelog entry I think

I don't think so.

But in general, what do you think about having a way to also look at commit messages when generating the changelog?
Then it could be added to the commit message when merging - without extra pushing etc.

@blueyed blueyed deleted the assert-compare-maxsize branch August 12, 2019 14:02
@nicoddemus
Copy link
Member

Not sure, we would need to see if it would be worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants