Remove/replace some unneeded usages of py.path #8440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
approved these changes
Mar 14, 2021
| @@ -5,9 +5,9 @@ | |||
| pytest_plugins = ("pytester",) | |||
|
|
|||
|
|
|||
| def test_failure_demo_fails_properly(testdir): | |||
| target = testdir.tmpdir.join(os.path.basename(failure_demo)) | |||
| def test_failure_demo_fails_properly(pytester): | |||
There was a problem hiding this comment.
as a followup we might want to make this use examples
There was a problem hiding this comment.
This one I'm not exactly sure where it's used, so left it as is.
doc/en/example/multipython.py
Outdated
| @@ -30,8 +30,8 @@ def __init__(self, version, picklefile): | |||
| self.picklefile = picklefile | |||
|
|
|||
| def dumps(self, obj): | |||
| dumpfile = self.picklefile.dirpath("dump.py") | |||
| dumpfile.write( | |||
| dumpfile = self.picklefile.parent / "dump.py" | |||
There was a problem hiding this comment.
lets use Path.with_name for those cases instead of path.parent / "newname"
doc/en/reference/unittest.rst
Outdated
| tmpdir.chdir() # change to pytest-provided temporary directory | ||
| tmpdir.join("samplefile.ini").write("# testdata") | ||
| def initdir(self, tmp_path): | ||
| os.chdir(tmp_path) # change to pytest-provided temporary directory |
There was a problem hiding this comment.
followup consideration: do we want to put monkeypatch.chdir in here for giving a better example
There was a problem hiding this comment.
Good idea, I changed to that.
bluetech
force-pushed
the
unnecessary-py-path
branch
from
e34d3f9 to
59251e8
Compare
|
failures is unrelated doc linkage issue cc @evildmp as that's probably going to be part of great loop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #8251 (comment) I am trying to find remaining py.path usages by completely removing it and seeing what breaks. These are the simple cases I found, mostly in the docs and tests. No user-facing changes.