-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
naturalsize output changed between 4.11.0 and 4.12.0 #239
Comments
Thanks for the report. This was caused by some bad formatting replacement in fb61d5a / #226. Let's fix it properly and make a patch release. As an aside, we get: >>> import humanize
>>> humanize.naturalsize(1.123456789 * 1000)
'1.1 kB'
>>> humanize.naturalsize(1.123456789 * 1000000)
'1.1 MB' So I think it would be better to also get: >>> humanize.naturalsize(1.123456789 * 1000000)
'1.1 Bytes' Instead of: >>> humanize.naturalsize(1.123456789 * 1000000)
'1 Bytes' But that's another issue. And we're definitely missing tests for non-integer input: humanize/tests/test_filesize.py Lines 14 to 75 in a0602c7
|
#240 adds tests and should revert to the previous behaviour. How does it look? |
We are apparently affected by this issue: python-humanize/humanize#239 Let's avoid that version and wait for a fix.
We are apparently affected by this issue: python-humanize/humanize#239 Let's avoid that version and wait for a fix.
Possibly a result of #218, we are seeing that the output has changed:
Expected behaviour is that output would not change in a minor version or that it would be documented in the release notes.
The text was updated successfully, but these errors were encountered: