Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APNG: Fix setting disposal #4726

Merged
merged 3 commits into from
Jun 29, 2020
Merged

APNG: Fix setting disposal #4726

merged 3 commits into from
Jun 29, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 24, 2020 •
edited
Loading

Changes proposed in this pull request:

  • This looks like a bug: should assign, rather than a comparison that has no effect
  • I don't have a test, but they pass before and after
  • Error on saving APNG #4725 isn't fixed by this

cc @pmrowla

@hugovk hugovk added Bug Any unexpected behavior, until confirmed feature. Cleanup labels Jun 24, 2020
@pmrowla
Copy link
Contributor

pmrowla commented Jun 24, 2020

this is definitely a bug, I can add a test case whenever I get to #4725

@radarhere radarhere mentioned this pull request Jun 29, 2020
Merged
@radarhere
Copy link
Member

I've created hugovk#52 to add a test.

@radarhere radarhere merged commit 4cf7c56 into python-pillow:master Jun 29, 2020
@hugovk hugovk deleted the fix-png-disposal-comparison-bug branch June 29, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Any unexpected behavior, until confirmed feature. Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @pmrowla @radarhere