Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dependency groups #26

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Add support for dependency groups #26

merged 4 commits into from
Nov 4, 2022

Conversation

tofay
Copy link
Contributor

@tofay tofay commented Aug 31, 2022

By making BundleCommand inherit from poetry's GroupCommand, and passing the detected groups through to the venv bundler.

Fixes #8

@SamambaMan
Copy link

Hey!

I need this SO BADLY and would be awesome if the PR were accepted.
Any chances? :D

Thanks for the great work

@connelldave
Copy link

Hello - ➕ this solves a blocking problem for my project. Curious if this is a change you're open to accepting? Thanks!

@mxab
Copy link

mxab commented Nov 2, 2022

This looks really helpful!
@neersighted would it be possible to ping the reviewers, would be a shame if that PR goes to waste :)

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late feedback. Overall this looks good to me. Can you add some simple tests with the different options in tests/console/commands/bundle/test_venv.py, please?

@tofay
Copy link
Contributor Author

tofay commented Nov 3, 2022

I've added the tests as requested.

@tofay tofay requested review from radoering and removed request for branchvincent November 3, 2022 21:18
@radoering radoering merged commit efe6f57 into python-poetry:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dependency groups
5 participants