gh-128540: Fixed webbrowser.open with file: URLs may launching editor instead of browser
#130031
Conversation
There was a problem hiding this comment.
This is a breaking change. I know of at least one instance where this will cause a significant break: by default the Pythons installed using the python.org macOS installers include a copy of the Python HTML documentation. On macOS, IDLE will look for that copy of the HTML documentation and, if found, will attempt to open it by passing a file: URL to webbrowser.open. Browsing the docs in IDLE is usually invoked with the F1 key. With this PR, pressing F1 causes IDLE to do nothing. There may be other existing users of webbrowser.open that would be similarly affected. I'm not sure what the best solution is but as it stands I don't think we can apply this as is.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
This seems to be a case of mutual exclusivity, where supporting the needs of some users without adding a new parameter might not be feasible given the existing calls in Python. There's no way to control what behavior users actually want. jupyter-server/jupyter_server#1488 My only idea is to introduce a new parameter, |
|
After thinking about it some more, I commented here on the issue. Let's try to resolve that first before proceeding further with a code change. Thanks for working on it! |
|
The current behavior of webbrowser still needs discussion, #128540 (comment) I decided to close it for now 😊 |
Solved : #128540