-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (GH-122566) #130268
Conversation
…4.04 (pythonGH-122566) (cherry picked from commit fc233f4) Co-authored-by: Damien <[email protected]>
Some Tk test failures on 2 tests failed:
test_tk test_ttk_guionly
10 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_nis
test_startfile test_winconsoleio test_winreg test_winsound
test_zipfile64
0:06:59 load avg: 2.88
0:06:59 load avg: 2.88 Re-running failed tests in verbose mode
0:06:59 load avg: 2.88 Re-running test_tk in verbose mode (matching: test_itemconfigure, test_configure_tabs)
patchlevel = 8.6.14
test_itemconfigure (tkinter.test.test_tkinter.test_widgets.ListboxTest) ... FAIL
test_configure_tabs (tkinter.test.test_tkinter.test_widgets.TextTest) ... FAIL
======================================================================
FAIL: test_itemconfigure (tkinter.test.test_tkinter.test_widgets.ListboxTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/cpython/cpython/Lib/tkinter/test/test_tkinter/test_widgets.py", line 1017, in test_itemconfigure
self.assertEqual(widget.itemconfigure(0, 'background'),
AssertionError: Tuples differ: ('background', '', '', '', 'red') != ('background', 'background', 'Background', '', 'red')
First differing element 1:
''
'background'
- ('background', '', '', '', 'red')
+ ('background', 'background', 'Background', '', 'red')
======================================================================
FAIL: test_configure_tabs (tkinter.test.test_tkinter.test_widgets.TextTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/cpython/cpython/Lib/tkinter/test/test_tkinter/test_widgets.py", line 678, in test_configure_tabs
self.checkParam(widget, 'tabs', '10.2 20.7 1i 2i',
File "/home/runner/work/cpython/cpython/Lib/tkinter/test/widget_tests.py", line 62, in checkParam
self.assertEqual2(widget[name], expected, eq=eq)
File "/home/runner/work/cpython/cpython/Lib/tkinter/test/widget_tests.py", line 46, in assertEqual2
self.assertEqual(actual, expected, msg)
AssertionError: Tuples differ: (10.2, 20.7, <pixel object: '1i'>, <pixel object: '2i'>) != ('10.2', '20.7', '1i', '2i')
First differing element 0:
10.2
'10.2'
- (10.2, 20.7, <pixel object: '1i'>, <pixel object: '2i'>)
+ ('10.2', '20.7', '1i', '2i')
----------------------------------------------------------------------
Ran 2 tests in 0.044s
AssertionError: Tuples differ: (0,) != ('0',)
First differing element 0:
0
'0'
- (0,)
+ ('0',)
? + +
======================================================================
FAIL: test_configure_padding (tkinter.test.test_ttk.test_widgets.TreeviewTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/cpython/cpython/Lib/tkinter/test/test_ttk/test_widgets.py", line 31, in test_configure_padding
self.checkParam(widget, 'padding', 0, expected=('0',))
File "/home/runner/work/cpython/cpython/Lib/tkinter/test/widget_tests.py", line 62, in checkParam
self.assertEqual2(widget[name], expected, eq=eq)
File "/home/runner/work/cpython/cpython/Lib/tkinter/test/widget_tests.py", line 46, in assertEqual2
self.assertEqual(actual, expected, msg)
AssertionError: Tuples differ: (0,) != ('0',)
First differing element 0:
0
'0'
- (0,)
+ ('0',)
? + + https://github.com/python/cpython/actions/runs/13393281565/job/37405891542?pr=130268 Also fail with https://github.com/hugovk/cpython/actions/runs/13393591071/job/37406977865 |
) Co-authored-by: Serhiy Storchaka <[email protected]>
…ents but 1 was given
OK, those are #107262, which tracks because Tk has been upgraded to 8.6.14. I've cherry picked it into this one and it passes (with a small adjustment). I've opened proper backports for that, let's merge those and then we can update it into this. |
Ready! @pablogsal This is like #130260 but for 3.10:
|
(cherry picked from commit fc233f4)
The
ubuntu-20.04
image is deprecated and will be fully unsupported by 2025-04-01: actions/runner-images#11101.Plus some other things like quotes and zizmor fixes from
main
.