Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42374: Allow unparenthesized walrus in genexps #23319

Merged
merged 3 commits into from
Nov 16, 2020
Merged

bpo-42374: Allow unparenthesized walrus in genexps #23319

merged 3 commits into from
Nov 16, 2020

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Nov 16, 2020 •
edited by miss-islington
Loading

This fixes a regression that was introduced by the new parser.

https://bugs.python.org/issue42374

Automerge-Triggered-By: GH:lysnikolaou

@lysnikolaou
bpo-42374: Allow unparenthesized walrus in genexps
1f188e4 
This fixes a regression that was introduced by the new parser.
@lysnikolaou lysnikolaou added the needs backport to 3.9 only security fixes label Nov 16, 2020
pablogsal
pablogsal approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🎣

@pablogsal
Copy link
Member

How did you find this? 🤔

@lysnikolaou
Copy link
Member Author

How did you find this?

@terryjreedy found it while working on #23291.

@miss-islington
Copy link
Contributor

@lysnikolaou: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit cb3e5ed into python:master Nov 16, 2020
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @lysnikolaou, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cb3e5ed0716114393696ec7201e51fe0595eab4f 3.9

@miss-islington miss-islington self-assigned this Nov 16, 2020
@lysnikolaou lysnikolaou deleted the unparenthesized-walrus-genexp branch November 16, 2020 23:09
lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Nov 16, 2020
@lysnikolaou
bpo-42374: Allow unparenthesized walrus in genexps (pythonGH-23319)
5244e21 
This fixes a regression that was introduced by the new parser.

(cherry picked from commit cb3e5ed)
@bedevere-bot
Copy link

GH-23329 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 16, 2020
@lysnikolaou lysnikolaou mentioned this pull request Nov 16, 2020
Merged
lysnikolaou added a commit that referenced this pull request Nov 16, 2020
@lysnikolaou
bpo-42374: Allow unparenthesized walrus in genexps (GH-23319) (GH-23329)
2b800ef 
This fixes a regression that was introduced by the new parser.

(cherry picked from commit cb3e5ed)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@lysnikolaou @adorilson
bpo-42374: Allow unparenthesized walrus in genexps (pythonGH-23319)
69434fb 
This fixes a regression that was introduced by the new parser.

Automerge-Triggered-By: GH:lysnikolaou
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

@miss-islington miss-islington

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysnikolaou @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni