-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-82616: Add process_group support to subprocess.Popen #23930
Conversation
Adds a setpgid parameter to subprocess APIs to help us deprecate uses of preexec_fn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is subprocess.Popen
, not subprocess.POpen
. Please fix the title and the news entry.
Misc/NEWS.d/next/Library/2020-12-24-19-11-53.bpo-38435.rEHTAR.rst
Outdated
Show resolved
Hide resolved
This PR is stale because it has been open for 30 days with no activity. |
Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
as suggested by Serhiy on the issue.
The Address sanitizer failure blocking this makes no logical sense. I cannot reproduce it on my systems because an address sanitizer build doesn't even work at all. Update: Zach Ware pointed out that I also needed to |
(post-merge review ;-)) LGTM. It might help to add a build check (C11 static_assert()) that the pid_t type is unsigned. A macro like that can be used:
|
Most recent one in python/cpython#23930. This makes me wish we could have had type evaluation functions.
Adds a
process_group=
parameter to subprocess APIs to help us deprecateuses of
preexec_fn
.https://bugs.python.org/issue38435