Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38435: Detect preexec_fn=os.setsid as start_new_session=True #23936

Closed
wants to merge 1 commit into from
Closed

bpo-38435: Detect preexec_fn=os.setsid as start_new_session=True #23936

wants to merge 1 commit into from

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Dec 25, 2020 •
edited by bedevere-bot
Loading

This is a somewhat common use case, this makes it more reliable.

I'd rather see code that does this be cleaned up. But until it is, this at least makes it more reliable and a little faster.

https://bugs.python.org/issue38435

@gpshead
bpo-38435: Detect preexec_fn=os.setsid as start_new_session=True
9d365ba 
This is a somewhat common use case, this makes it more reliable.
@gpshead gpshead added type-feature A feature request or enhancement and removed awaiting core review labels Dec 25, 2020
izbyshev
izbyshev reviewed Dec 26, 2020
View reviewed changes
Copy link
Contributor

@izbyshev izbyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your intent to keep this for reducing compat breakage after real preexec_fn support is removed? Otherwise, it seems like having preexec_fn=os.sid perform slower and less reliably would be more helpful in motivating users to migrate to start_new_session :)

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 26, 2021
@gpshead
Copy link
Member Author

gpshead commented Dec 18, 2021

this special case won't do a lot as it is one of many. we need to solve the greater problem of providing a way for all actually needed actions to be taken before exec. abandoning this mini idea.

@gpshead gpshead closed this Dec 18, 2021
@gpshead gpshead mentioned this pull request May 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izbyshev izbyshev izbyshev left review comments

Assignees
No one assigned
Labels
stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpshead @izbyshev @the-knights-who-say-ni @bedevere-bot