bpo-43795 - Update Stable ABI dat. #25716
Conversation
| @@ -286,9 +286,6 @@ PyFrame_GetLineNumber | |||
| PyFrozenSet_New | |||
| PyFrozenSet_Type | |||
| PyGC_Collect | |||
| PyGC_Disable | |||
There was a problem hiding this comment.
This doesn't look right to me and don't know how to read this.
This was the output of make regen-limited-abi
There was a problem hiding this comment.
@encukou - Please verify if this is correct.
There was a problem hiding this comment.
No, that's not correct. Those should stay in the file.
There was a problem hiding this comment.
They probably need to get added to Misc/stable_abi.txt now. That seems to be the new source of truth. I'll add them there.
There was a problem hiding this comment.
@scoder - Thank you. I could update this PR with Misc/stable_abi.txt change too.
There was a problem hiding this comment.
Petr took care of it - #25720
orsenthil
changed the title
|
Oh, these are new symbols that got in as I merged PEP 652 commit. Sorry for the mismatch; I'll add them. |
|
Updating this PR at the correct location. |
|
See GH-25720 |
|
Thank you. This is resolved by #25720 |
PRs were failing with the check if generated files are up to date. For e.g this one.
The Stable ABI was updated here in this PR - #25315
The change in this diff was introduced here - 3cc481b
I had run
make regen-limited-abito recrete the stable abi manifest.https://bugs.python.org/issue43774