Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43795 - Update Stable ABI dat. #25716

Closed
wants to merge 1 commit into from
Closed

bpo-43795 - Update Stable ABI dat. #25716

wants to merge 1 commit into from

Conversation

orsenthil
Copy link
Member

@orsenthil orsenthil commented Apr 29, 2021

PRs were failing with the check if generated files are up to date. For e.g this one.

The Stable ABI was updated here in this PR - #25315
The change in this diff was introduced here - 3cc481b

I had run make regen-limited-abi to recrete the stable abi manifest.

https://bugs.python.org/issue43774

@orsenthil orsenthil changed the title Update Stable ABI dat. bpo-43774 - Update Stable ABI dat. Apr 29, 2021
@@ -286,9 +286,6 @@ PyFrame_GetLineNumber
PyFrozenSet_New
PyFrozenSet_Type
PyGC_Collect
PyGC_Disable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right to me and don't know how to read this.

This was the output of make regen-limited-abi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@encukou - Please verify if this is correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's not correct. Those should stay in the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They probably need to get added to Misc/stable_abi.txt now. That seems to be the new source of truth. I'll add them there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scoder - Thank you. I could update this PR with Misc/stable_abi.txt change too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petr took care of it - #25720

@orsenthil orsenthil requested a review from encukou April 29, 2021 11:57
@orsenthil orsenthil changed the title bpo-43774 - Update Stable ABI dat. bpo-43795 - Update Stable ABI dat. Apr 29, 2021
@orsenthil orsenthil requested a review from scoder April 29, 2021 12:49
@encukou
Copy link
Member

encukou commented Apr 29, 2021

Oh, these are new symbols that got in as I merged PEP 652 commit. Sorry for the mismatch; I'll add them.
Details are in PEP 652, while I'm finishing up proper docs.

@orsenthil
Copy link
Member Author

Updating this PR at the correct location.

@encukou
Copy link
Member

encukou commented Apr 29, 2021

See GH-25720

@orsenthil
Copy link
Member Author

Thank you. This is resolved by #25720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants