-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43795 - Update Stable ABI dat. #25716
Conversation
@@ -286,9 +286,6 @@ PyFrame_GetLineNumber | |||
PyFrozenSet_New | |||
PyFrozenSet_Type | |||
PyGC_Collect | |||
PyGC_Disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right to me and don't know how to read this.
This was the output of make regen-limited-abi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@encukou - Please verify if this is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's not correct. Those should stay in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They probably need to get added to Misc/stable_abi.txt
now. That seems to be the new source of truth. I'll add them there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scoder - Thank you. I could update this PR with Misc/stable_abi.txt change too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Petr took care of it - #25720
Oh, these are new symbols that got in as I merged PEP 652 commit. Sorry for the mismatch; I'll add them. |
Updating this PR at the correct location. |
See GH-25720 |
Thank you. This is resolved by #25720 |
PRs were failing with the check if generated files are up to date. For e.g this one.
The Stable ABI was updated here in this PR - #25315
The change in this diff was introduced here - 3cc481b
I had run
make regen-limited-abi
to recrete the stable abi manifest.https://bugs.python.org/issue43774