Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules #31358

Merged
merged 3 commits into from
Feb 16, 2022
Merged

bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules #31358

merged 3 commits into from
Feb 16, 2022

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 15, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 15, 2022 •
edited
Loading

You need to regenerate global objects. Either run Tools/scripts/generate_global_objects.py, or do make regen-global-objects (I prefer the former as I build out of tree).

Sorry, close is already there :)

erlend-aasland
erlend-aasland approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as far as I can see. Let's wait and hear what Eric says.

@ericsnowcurrently
Copy link
Member

I have reservations. See #31351 (comment).

@ericsnowcurrently
Copy link
Member

Also, thanks for working on this! 🙂

@corona10 corona10 changed the title bpo-46541: Replace _Py_IDENTIFIER with _Py_ID in dbms modules bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules Feb 16, 2022
@corona10 corona10 force-pushed the bpo-46541-dbms branch 2 times, most recently from d450463 to dc57f78 Compare February 16, 2022 02:29
@corona10
Copy link
Member Author

@ericsnowcurrently @ericsnowcurrently
PTAL :)

erlend-aasland
erlend-aasland approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@corona10 corona10 merged commit e59309b into python:main Feb 16, 2022
@corona10 corona10 deleted the bpo-46541-dbms branch February 16, 2022 09:57
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @erlend-aasland @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot